Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the conformance test suite #2432

Merged
merged 35 commits into from
May 23, 2024
Merged

Updates to the conformance test suite #2432

merged 35 commits into from
May 23, 2024

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented May 17, 2024

Blocked on: runtimeverification/k#4370
Blocked on: #2439

  • Update all actions/checkout from v3 => v4 and Gr1N/setup-poetry from v8 => v9 to get rid of NodeJS deprecation warnings on actions runs.
  • Updates Poetry to v1.8.3.
  • Switch us off the LegacyTests directory in the Ethereum test-suite completely.
  • Avoid cloning submodules recursively in almost all cases (saves 1-2min per job or so).
    • Interactive tests in unit/profiling/nix have the files they used copied directly into this repository instead.
    • Conformance test stage still does recursive submodule clone, because it needs the test-suite. In this case, it's still faster to let GH action runner manage the clone with caching.
    • Many stages only recursively clone the plugin submodule manually after doing a non-recursive code checkout.
  • Break each conformance test into an individual run, instead of batch-running them. Logging messages for each as well.
  • Does not run the VMTests twice (once in BChain tests and once on its own).
  • Does not run each conformance test twice (once in normal tests, once in legacy).

@ehildenb ehildenb self-assigned this May 17, 2024
@ehildenb
Copy link
Member Author

Before:

image

After:

image

@Baltoli
Copy link
Contributor

Baltoli commented May 21, 2024

Blocked on: #2439

@ehildenb ehildenb marked this pull request as ready for review May 22, 2024 15:30
@ehildenb ehildenb requested review from Baltoli and anvacaru May 22, 2024 15:30
.github/workflows/test-pr.yml Show resolved Hide resolved
flake.nix Show resolved Hide resolved
@rv-jenkins rv-jenkins merged commit cc3c92b into master May 23, 2024
11 checks passed
@rv-jenkins rv-jenkins deleted the new-gst branch May 23, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants