Support for multimasks in slot updates #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvacaru
approved these changes
Dec 16, 2024
automergerpr-permission-manager
bot
deleted the
petar/slot-updates-update
branch
anvacaru
pushed a commit
that referenced
this pull request
Dec 18, 2024
* support for multimasks * syntax correction * test correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in engagement code, the compiler can sometimes use a multi-mask (in this case, specifically
1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111000000000000000000000000000000001111111111111111111111111111111111111111000000000000000000000000000000001111111111111111111111111111111111111111) to presumably save an&Intin consecutive updates of the same storage slot. Previously, the automated slot updates could only handle masks with a single batch of zeros.This PR generalises the slot updates to support multi-masks and adds an appropriate real-world test.