Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc 4 kontrol.toml #65

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Doc 4 kontrol.toml #65

wants to merge 7 commits into from

Conversation

Stevengre
Copy link
Contributor

  • provide all options for kontrol.toml

@Stevengre Stevengre self-assigned this Nov 18, 2024
Copy link
Contributor

@palinatolmach palinatolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. Could you please also make sure that you can run kontrol commands in a project with this kontrol.toml file?

README.md Outdated
@@ -13,6 +13,8 @@ layout:
visible: true
---

# Kontrol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was removed in the previous PR:

Suggested change
# Kontrol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the next empty line too.

module-import = 'TestBase:KONTROL-LEMMAS'
auxiliary-lemmas = true

# ? definition_dir = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this question mark indicate? I think it's ok to just leave these options commented, e.g.,

# definition_dir = None

or even

# definition_dir =

# ? spec_module = None

[build]
# Directories to lookup K definitions in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't put comments below or after the options. How about placing them next to the option instead? E.g.,

# include = [] # Directories to lookup K definitions in.

no-stack-checks = true

[prove]
-I INCLUDES Directories to lookup K definitions in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update those values too.

README.md Outdated
Comment on lines 16 to 17
# Kontrol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Kontrol

# spec_module =

[build]
backend = # K backend to target with compilation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's allowed in a non-comment line, please consider changing it (and other similar lines) to the following:

Suggested change
backend = # K backend to target with compilation.
# backend = # K backend to target with compilation.

Please check if kontrol build, prove, etc. works with this kontrol.toml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed these options. I'll check it again.

Copy link
Contributor Author

@Stevengre Stevengre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • kontrol build passed.
  • kontrol prove worked, but setup function costs more time than expected and still not finished.
  • kontrol show unchecked.
Running setup functions in parallel: test%CounterTest.setUp()
⠇ 0:04:23 test%CounterTest.setUp():0 Running proof PENDING: 35 nodes: 9 pending|5 passed|0 failing|0 vacuous|0 refuted|0 stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants