Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run unit test as part of integration tests #3827

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

geo2a
Copy link
Collaborator

@geo2a geo2a commented Apr 23, 2024

I've noticed we are running unit test as part of the "'Nix / Integration'" job, but we also have a dedicated "'Nix / Unit Tests" job that runs them in exactly the same way, so we may as well skip them in the integration tests job.

@jberthold
Copy link
Member

This was in preparation to replace the Nix / Unit tests job by one that runs both integration tests and unit tests on all platforms we aim to support, see #3816 .
This is currently on hold because of an issue on Mac M1 that I cannot debug locally.
Happy to remove the unit test run step for the moment.

@geo2a
Copy link
Collaborator Author

geo2a commented Apr 24, 2024

Ah, right, sorry to tread on your toes @jberthold.

@rv-jenkins rv-jenkins merged commit 089deaf into master Apr 24, 2024
7 checks passed
@rv-jenkins rv-jenkins deleted the georgy/ci branch April 24, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants