Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booster Description #4066

Merged
merged 14 commits into from
Dec 3, 2024
Merged

Booster Description #4066

merged 14 commits into from
Dec 3, 2024

Conversation

geo2a
Copy link
Collaborator

@geo2a geo2a commented Oct 28, 2024

This PR adds prose documentation for Booster --- a fast symbolic rewrite engine for K.

Some of the prose and the rewriting diagram have been contributed earlier by Sam Balco.

@geo2a geo2a force-pushed the booster-docs branch 2 times, most recently from af650a9 to 9e7056e Compare October 29, 2024 13:04
@geo2a geo2a marked this pull request as ready for review October 31, 2024 14:31
@geo2a geo2a requested review from jberthold and ehildenb October 31, 2024 14:31
Comment on lines +143 to +144
- rule matching can be indeterminate. We really do not want this to happen, as it will abort rewriting and cause a fallback to Kore (or a full-stop of using the `booster-dev` server).
Common cases include unevaluated function symbols. See [match1](https://github.com/runtimeverification/haskell-backend/blob/master/booster/library/Booster/Pattern/Match.hs#L191) and look for `addIndetermiante` for the exhaustive list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you point out unevaluated functions. I think we should add some concrete examples here.

docs/2024-10-18-booster-description.md Outdated Show resolved Hide resolved
docs/2024-10-18-booster-description.md Outdated Show resolved Hide resolved
docs/2024-10-18-booster-description.md Outdated Show resolved Hide resolved
docs/2024-10-18-booster-description.md Outdated Show resolved Hide resolved
docs/2024-10-18-booster-description.md Outdated Show resolved Hide resolved
@jberthold jberthold requested a review from tothtamas28 December 3, 2024 10:17
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's skip the examples for now to get this merged

@rv-jenkins rv-jenkins merged commit 097e560 into master Dec 3, 2024
6 checks passed
@rv-jenkins rv-jenkins deleted the booster-docs branch December 3, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants