Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging: Move version into lib/kframework #3683

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Packaging: Move version into lib/kframework #3683

merged 2 commits into from
Oct 3, 2023

Conversation

gtrepta
Copy link
Contributor

@gtrepta gtrepta commented Sep 29, 2023

For #3675

We're installing version into /usr/lib/version. This change moves it to /usr/lib/kframework/version.

@gtrepta gtrepta mentioned this pull request Sep 29, 2023
Closed
@gtrepta gtrepta marked this pull request as ready for review October 3, 2023 13:53
@gtrepta gtrepta requested review from dwightguth and ehildenb October 3, 2023 13:53
@ehildenb
Copy link
Member

ehildenb commented Oct 3, 2023

Are there any bash scripts that read this file directly? Does krun --version call the JVM or just read the file directly, for example?

@gtrepta
Copy link
Contributor Author

gtrepta commented Oct 3, 2023

Are there any bash scripts that read this file directly? Does krun --version call the JVM or just read the file directly, for example?

The scripts are calling kompile --version

@rv-jenkins rv-jenkins merged commit 71a0669 into develop Oct 3, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the version-file branch October 3, 2023 20:02
@Robertorosmaninho
Copy link
Collaborator

Robertorosmaninho commented Oct 4, 2023 •
edited
Loading

Actually, krun, kast, kompile, and other tools call this script k, which is responsible for printing the --version by reading it from this file. We don't start the JVM anymore to get the K version.

This modification caused this issue: #3690

@gtrepta
Copy link
Contributor Author

gtrepta commented Oct 4, 2023

Uuuugh. I tested the packaging locally hoping to catch something like this, but the tests must not be covering it.

@gtrepta gtrepta mentioned this pull request Oct 4, 2023
Merged
rv-jenkins added a commit that referenced this pull request Oct 4, 2023
@gtrepta @Robertorosmaninho @rv-jenkins
Packaging: version path fix (#3691)
b3c4644 
Follow up to finish #3683

---------

Co-authored-by: Roberto Rosmaninho <[email protected]>
Co-authored-by: rv-jenkins <[email protected]>
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehildenb ehildenb ehildenb approved these changes

@dwightguth dwightguth Awaiting requested review from dwightguth

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gtrepta @ehildenb @Robertorosmaninho @rv-jenkins