Make bison parser enabled by default #3721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 17, 2023 13:06
radumereuta
reviewed
Oct 25, 2023
| @@ -396,60 +397,79 @@ private static void processProduction(Production prod, Module module, Module dis | |||
| " node *n = malloc(sizeof(node) + sizeof(node *));\n" + | |||
| " n->str = false;\n" + | |||
| " n->location = @$;\n" + | |||
| " n->hasLocation = " + (hasLocation ? "1" : "0") + ";\n" + | |||
There was a problem hiding this comment.
@Baltoli with Java 15, you can do multiline strings which hopefully will make this look a bit nicer.
added 2 commits
October 25, 2023 10:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1741
This enables the bison parser by default everywhere. We can still get the old jit parser behavior by passing a flag.
Not ready for review yet; still needs more testing.