Fix for macOS nix / kup breakage #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
approved these changes
Oct 23, 2023
|
Thought I was being clever using |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Intel mac machine, the minimal JRE package is broken:
This causes the default
kup-installed K to break; the fix is just to identify this platform and package the full JRE. The only downside here is a slightly bigger closure for users on this platform, which is likely to be deprecated at some point in the future anyway.I have also added a new minimal "smoke test" to the Nix CI tests; previously we were not checking that
kompileetc. actually run on Intel macOS.