Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #parseKORE #3850

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Remove #parseKORE #3850

merged 2 commits into from
Dec 7, 2023

Conversation

Scott-Guest
Copy link
Contributor

@Scott-Guest Scott-Guest commented Dec 6, 2023 •
edited
Loading

Per discussion in the frontend meeting, this PR removes #parseKORE because it is

  • deprecated in modern K in favor of Pyk-based approaches
  • unused by all of our active semantics
  • type unsafe (and I am on a crusade to patch all type safety violations 😄)

Related: runtimeverification/llvm-backend#919, runtimeverification/haskell-backend#3701

@Scott-Guest Scott-Guest self-assigned this Dec 6, 2023
This was referenced Dec 6, 2023
Merged
Merged
@Baltoli
Copy link
Contributor

Baltoli commented Dec 6, 2023 •
edited
Loading

They're not actively maintained, but for completeness open an issue on:

to make this issue explicit.

@Scott-Guest Scott-Guest requested a review from Baltoli December 6, 2023 17:56
@Scott-Guest Scott-Guest marked this pull request as ready for review December 6, 2023 17:56
Baltoli
Baltoli approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; once this is merged I'll approve + merge the backend PRs as well.

@rv-jenkins rv-jenkins merged commit e55ef5d into develop Dec 7, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the parse-kore-no-more branch December 7, 2023 10:43
rv-jenkins pushed a commit to runtimeverification/haskell-backend that referenced this pull request Dec 7, 2023
@Scott-Guest
Remove references to #parseKORE (#3701)
a584730 
This PR removes all references to the deprecated `#parseKORE` hook

Paired with runtimeverification/k#3850,
runtimeverification/llvm-backend#919
rv-jenkins pushed a commit to runtimeverification/llvm-backend that referenced this pull request Dec 7, 2023
@Scott-Guest
Remove #parseKORE (#919)
87eefda 
This PR removes the deprecated `#parseKORE` hook.

Dependencies before merge: runtimeverification/k#3850,
runtimeverification/haskell-backend#3701
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baltoli Baltoli Baltoli approved these changes

@dwightguth dwightguth Awaiting requested review from dwightguth

@ehildenb ehildenb Awaiting requested review from ehildenb ehildenb is a code owner

Assignees

@Scott-Guest Scott-Guest

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scott-Guest @Baltoli @rv-jenkins