Support strict casts in the SimpleSub inferencer #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Scott-Guest
force-pushed
the
simplesub-strict-casts
branch
2 times, most recently
from
28b2a2c to
3bd2f67
Compare
Scott-Guest
force-pushed
the
simplesub-strict-casts
branch
from
3bd2f67 to
23aa1e7
Compare
radumereuta
reviewed
Dec 18, 2023
| @@ -445,7 +445,7 @@ private Tuple2<Either<Set<KEMException>, Term>, Set<KEMException>> parseStringTe | |||
| boolean equalRight = | |||
| rez.isRight() && z3Rez.isRight() && rez.right().get().equals(z3Rez.right().get()); | |||
| if (!(bothLeft || equalRight)) { | |||
| throw KEMException.criticalError("Z3 and SimpleSub algorithms differ!"); | |||
| throw typeInferenceCheckError(rez3, z3Rez, rez); | |||
There was a problem hiding this comment.
Do you have any examples of such differences?
It would be interesting to document them and add regression tests.
There was a problem hiding this comment.
I'm not aware of any actual differences - the improved error message was just useful while debugging when I unintentionally broke something and caused a difference
radumereuta
approved these changes
Dec 18, 2023
Baltoli
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3848.
CHECKEDmode