-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Checkstyle to Spotless #3874
Conversation
e1954e2
to
f1b3be8
Compare
f1b3be8
to
a591a4e
Compare
k-distribution/pl-tutorial/2_languages/1_simple/2_typed/1_static/simple-typed-static.md
Outdated
Show resolved
Hide resolved
… newlines, and spaces over tabs
a591a4e
to
276d897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now, although very large.
Maybe someone else can have a look. If not, you can merge in a few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me also (once my laptop had loaded the diff page!)
This PR migrates all of our formatting checks from the Checkstyle plugin to the Spotless plugin.
As a result,
mvn package
(ormvn spotless:apply
ormvn process-sources
) automatically fixes any formatting violations, e.g., inserting copyright headers for you.The diff is large, but the only non-automated code changes are in
pom.xml
andsrc/main/config/checkstyle-*.xml
All the behavior is the exact same except:
Copyright \(c\) (Runtime Verification, Inc|K Team). All Rights Reserved.
, but now we only accept theRuntime Verification, Inc
version due to limitations of Spotless. All existing headers were converted automaticallyRuntime Verification, Inc