Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing case in semantics for string replace function #3910

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Fix missing case in semantics for string replace function #3910

merged 5 commits into from
Jan 22, 2024

Conversation

gtrepta
Copy link
Contributor

@gtrepta gtrepta commented Jan 18, 2024

fixes: #3896

@gtrepta gtrepta marked this pull request as ready for review January 18, 2024 18:51
@gtrepta gtrepta requested review from Baltoli and sskeirik January 18, 2024 18:51
sskeirik
sskeirik approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@sskeirik sskeirik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Baltoli
Baltoli approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and it seems like you're both in agreement here!

@rv-jenkins rv-jenkins merged commit 2743d63 into develop Jan 22, 2024
8 checks passed
@rv-jenkins rv-jenkins deleted the string-replace-fix branch January 22, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sskeirik sskeirik sskeirik approved these changes

@Baltoli Baltoli Baltoli approved these changes

@dwightguth dwightguth Awaiting requested review from dwightguth

@ehildenb ehildenb Awaiting requested review from ehildenb ehildenb is a code owner

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gtrepta @Baltoli @sskeirik @rv-jenkins