Implement i64 and i128 Types and Host Functions
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACassimiro
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Looks good to me and I don't have any issues with the implementation. Something has been bothering me a bit, though. As we continue expanding the implementation of the host functions, it would be nice to have references to their original implementation on top of the rules. The reasoning here is that, at least for me, the hostCall parameters are not necessarily friendly with regard to user readability. Still, this is not a blocker for me.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds semantics for handling of the
i64andi128types, and host functions to operate with these types:obj_from_i64: Creates aScValfrom Wasmi64and returns theHostValrepresenting thisScVal.obj_from_i128_pieces: Constructs anI128object from twoi64parts (high and low).obj_to_i128_loandobj_to_i128_hi: Extracts the high/lowi64portion of anI128object.