Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency: deps/kevm_release #579

Merged
merged 22 commits into from
May 27, 2024

Conversation

rv-jenkins
Copy link
Collaborator

@rv-jenkins rv-jenkins commented May 23, 2024

@palinatolmach
Copy link
Collaborator

Strange — in the latest CI run, several tests failed because Kontrol doesn't recognize some of the cheatcodes:

E                   K_CELL: #cheatcode_error selector ( "freshBool()" ) b""
E                   ~> #cheatcode_return 128 32

Will re-run locally.

@palinatolmach
Copy link
Collaborator

The failure intest_bool

function test_bool() public {
uint256 fresh_uint256 = kevm.freshBool();

reproduces locally too:

K_CELL: #cheatcode_error selector ( "freshBool()" ) b""
                  ~> #cheatcode_return 128 32

The same happens in the test using kevm.symbolicStorage(address). Both cheatcodes are defined in {.k .symbolic} blocks. @tothtamas28 @anvacaru is it possible that those are not getting kompiled/included in kompilation after runtimeverification/evm-semantics#2427?

@tothtamas28
Copy link
Contributor

is it possible that those are not getting kompiled/included in kompilation after runtimeverification/evm-semantics#2427?

Let me check.

@tothtamas28
Copy link
Contributor

is it possible that those are not getting kompiled/included in kompilation after runtimeverification/evm-semantics#2427?

Let me check.

Seems to be the case, good catch. I'll revert the PR.

@palinatolmach
Copy link
Collaborator

Thanks @tothtamas28!

@palinatolmach palinatolmach merged commit 36e6994 into master May 27, 2024
13 of 14 checks passed
@palinatolmach palinatolmach deleted the _update-deps/runtimeverification/evm-semantics branch May 27, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants