Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit the branch name when matching packages in manifest.json #131

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

anvacaru
Copy link
Contributor

@anvacaru anvacaru commented Dec 2, 2024

Closes: #130
The kontrol package is defined in available_packages with a specific branch:

    GithubPackage('runtimeverification', 'kontrol', PackageName('kontrol'), branch='release'),

From the manifest.json, we can see that the kontrol entry looks like this:

{
  "kontrol": {
    "active": true,
    "attrPath": "packages.x86_64-linux.kontrol",
    "originalUrl": "github:runtimeverification/kontrol/acca16ffd6f4e693b7bda2dd8ca99eb335057dbe?narHash=...",
    "url": "github:runtimeverification/kontrol/acca16ffd6f4e693b7bda2dd8ca99eb335057dbe?narHash=..."
  },
}

When kup tries to match the installed packages with the available packages, it compares the repo_path (which includes the branch) with the url from the manifest (which does not include the branch). This mismatch causes kup to incorrectly conclude that kontrol is not installed.

image

@anvacaru anvacaru merged commit ead48a2 into master Dec 2, 2024
1 check passed
@anvacaru anvacaru deleted the anvacaru/list_kontrol branch December 2, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kup list doesn't show the installed version of kontrol
2 participants