Hotfix for K LLVM backend update #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
requested review from
theo25,
dwightguth,
Scott-Guest,
Robertorosmaninho and
gtrepta
dwightguth
reviewed
Oct 19, 2023
dwightguth
approved these changes
Oct 19, 2023
rv-jenkins
pushed a commit
that referenced
this pull request
Oct 19, 2023
This PR follows up on #869 to refactor our use of CMake to configure C++ code with build-specific information. Instead of configuring individual files, we push all `@...@` stanzas into `config/macros.h` and use that file as the single source of configured literals. There is a small change to the implementation of the LLVM header in `CreateTerm.h` to support this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a hotfix for a broken backend update job.
When using the new inlined version of
llvm-kompile, we were incorrectly using the result ofsys::getDefaultTargetTriple()as our target for machine code emission, rather than the consistent value selected by running Clang on an empty input file.On newer versions of macOS, this produces warnings like:
when running
llvm-kompile. These warnings were silently absorbed by CI as they are just warnings, but they are a) noisy and b) break the K test suite when grepping for error messages in failed compilations (kompile ... 2>&1 | grep ...).The fix is just to use our existing technique for target triple selection in the one place we weren't previously.
Additionally, the PR makes two small related changes:
llvm-kompileis silent and doesn't pollutestderrwith extra output when it runs successfully