Adopt scalafmt for Scala code style #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Baltoli
requested review from
dwightguth,
Scott-Guest,
Robertorosmaninho,
gtrepta and
theo25
Robertorosmaninho
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Overall LGTM! I would expect @Scott-Guest to approvals for a more precise review of the config files!
Scott-Guest
reviewed
Dec 11, 2023
Scott-Guest
reviewed
Dec 11, 2023
Scott-Guest
reviewed
Dec 11, 2023
| @@ -0,0 +1,27 @@ | |||
| version = 3.7.17 | |||
There was a problem hiding this comment.
I'm fine with duplicating the files for now, but we should consider pulling in .scalafmt.conf from the parent project in a follow up PR.
Scott-Guest
approved these changes
Dec 11, 2023
gtrepta
approved these changes
Dec 11, 2023
|
Thanks @Scott-Guest - I didn't realise Maven worked like that! |
|
I have addressed the duplicated configuration elements; going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In runtimeverification/k#3841, we adopted the
scalafmttool to auto-format the Scala code in the K frontend. This PR adopts a precisely identical formatting setup for the LLVM backend's Scala code.