Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pylsp #37

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Move to pylsp #37

wants to merge 6 commits into from

Conversation

s7726
Copy link

@s7726 s7726 commented May 1, 2021

#35

Attempt to move this over.

s7726 added 4 commits May 1, 2021 14:29
Switch dependency to pylsp instead of the unmaintained pyls.
haplo
haplo previously approved these changes May 12, 2021
Copy link

@haplo haplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW these changes look good to me.

As palantir's python-language-server is unmaintained I would very much like for pyls-black to go with the maintained implementation.

@@ -14,7 +14,7 @@ classifiers =

[options]
packages = find:
install_requires = python-language-server; black>=19.3b0; toml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the entry_points update

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why... It's pushed to the patch-1 branch.

No actual change (space at end of line), just trying to trigger the pull-request machine
Reverse the space at the end of the line to get back to a clean file
@s7726
Copy link
Author

s7726 commented May 15, 2021

Alright, yeah I don't know why that didn't push through before. This whole thing should be squashed anyway so it should be one nice clean commit when done.

@JamieMagee JamieMagee mentioned this pull request Jan 1, 2023
7 tasks
netgate-git-updates pushed a commit to pfsense/FreeBSD-ports that referenced this pull request Jan 14, 2023
Conversion from python-language-server (deprecated) to python-lsp-server by cherry picking from Github[1][2].

No conversion to PEP517, since 2023Q1 does not contain it. This will be done in a follow up commit.

[1] rupert/pyls-black#37
[2] rupert/pyls-black#41

PR:		268342
Reported by:	[email protected]
MFH:		2023Q1
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Jan 14, 2023
Conversion from python-language-server (deprecated) to python-lsp-server by cherry picking from Github[1][2].

No conversion to PEP517, since 2023Q1 does not contain it. This will be done in a follow up commit.

[1] rupert/pyls-black#37
[2] rupert/pyls-black#41

PR:		268342
Reported by:	[email protected]
MFH:		2023Q1

(cherry picked from commit 4b0bcfb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants