Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dav1d 1.3.0 #83

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Update to dav1d 1.3.0 #83

merged 1 commit into from
Oct 31, 2023

Conversation

sdroege
Copy link
Contributor

@sdroege sdroege commented Oct 24, 2023

dav1d 1.3.0 breaks API and ABI, so this is a breaking change on the Rust side too.


This is on top of #82, so let's merge that one first, do a release, then merge this one, do a new release.

@sdroege sdroege requested a review from lu-zero October 24, 2023 06:34
@lu-zero
Copy link
Member

lu-zero commented Oct 24, 2023

I guess upstream dislikes semver quite a bit.

Copy link
Member

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but needs a rebase.

@sdroege
Copy link
Contributor Author

sdroege commented Oct 24, 2023

Rebased

@sdroege
Copy link
Contributor Author

sdroege commented Oct 24, 2023

You tag and release 0.9.5 before merging this?

@lu-zero
Copy link
Member

lu-zero commented Oct 24, 2023

Sure, could you please remind me in 4 hours in case I forgot? (another hectic day)

@sdroege
Copy link
Contributor Author

sdroege commented Oct 24, 2023

Sure :) If you want to give me access to the two crates I can also take care of it, as you prefer

dav1d-sys/Cargo.toml Outdated Show resolved Hide resolved
dav1d 1.3.0 breaks API and ABI, so this is a breaking change on the Rust side too.
@sdroege
Copy link
Contributor Author

sdroege commented Oct 31, 2023

@lu-zero Should be good now

@lu-zero lu-zero merged commit 3a5c34b into rust-av:master Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants