Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.0-alpha #119

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jul 26, 2023

In preparation for doing an alpha release of the new primitives crate bump the version to 0.10.0-alpha and add a changelog entry.

Let's Go!

@tcharding tcharding changed the title Release 0.10.0 alpha Release v0.10.0-alpha Jul 26, 2023
@tcharding tcharding changed the title Release v0.10.0-alpha Tracking PR for release v0.10.0-alpha Jul 26, 2023
@tcharding tcharding force-pushed the 07-25-release-0.10.0-alpha branch from 323a175 to 9caa5df Compare August 1, 2023 05:46
@tcharding
Copy link
Member Author

@clarkmoody could you please concept ack/nack?

@clarkmoody
Copy link
Member

ACK from me 👍

@tcharding
Copy link
Member Author

Legend.

In preparation for doing an `alpha` release of the new `primitives`
crate bump the version to `0.10.0-alpha` and add a changelog entry.

ref: https://doc.rust-lang.org/cargo/reference/resolver.html#pre-releases
@tcharding tcharding force-pushed the 07-25-release-0.10.0-alpha branch from 9caa5df to 202df4f Compare August 17, 2023 00:42
@tcharding tcharding marked this pull request as ready for review August 17, 2023 00:42
@tcharding tcharding changed the title Tracking PR for release v0.10.0-alpha Release v0.10.0-alpha Aug 17, 2023
@apoelstra
Copy link
Member

@tcharding is this good to go? Like, if we merge this can we do the release?

@tcharding
Copy link
Member Author

Yep we are good to go, merge and release please.

@apoelstra
Copy link
Member

apoelstra commented Aug 18, 2023

@tcharding could you rebase this to remove the overlapping code from #118? It looks like this isn't causing merge conflicts but I think that's git being too smart for its own good.

Never mind, I needed to fetch the latest version of the branch. More like me being too dumb for my own good..

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 202df4f

@apoelstra apoelstra merged commit 465632e into rust-bitcoin:master Aug 18, 2023
@apoelstra apoelstra deleted the 07-25-release-0.10.0-alpha branch August 18, 2023 13:54
@apoelstra
Copy link
Member

Oops, I should've done cargo publish --dry-run before merging.

@tcharding crates.io says we need to remove one of the keywords from Cargo.toml (have 5, max 6). Added in #98.

@tcharding
Copy link
Member Author

Done, #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants