-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cookbook): PSBTs multiple inputs #32
Conversation
9b4c0aa
to
fb8e19b
Compare
Ready to review guys! |
@@ -7,7 +7,7 @@ cat << EOF > src/lib.rs | |||
extern crate doc_comment; | |||
EOF | |||
|
|||
for doc in ../src/*.md | |||
for doc in ../src/**/*.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new examples are in a nested dir inside src/
.
That's why this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started reviewing but then realised, while struggling with reviewing code in either the markdown file or the rendered HTML, that for the other cookbook stuff I did a PR into rust-bitcoin/bitcoin/examples
first.
Any chance you would be willing to do that also, then we can review the code like normal and copying it to the cookbook is just a matter of cut'n'pasting the relevant bits.
Yes of course! That's why I PR'd here only and first. |
e2fe60f
to
6ad3acc
Compare
Co-authored-by: Tobin C. Harding <[email protected]>
6ad3acc
to
81c90e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 81c90e6
Adds examples on how to create, update, sign, and finalize PSBTs version 0 that deals with multiple inputs.
Examples are SegWit V0 and Taproot.
*.md
filesCloses #26.