-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix incorrect FFI binding for pubkey_combine #670
Conversation
aaa9c16
to
68d021b
Compare
68d021b
to
484e5d8
Compare
I rekon if we are going to backport this would be nicer have a bit more description in the commit log. ACK 484e5d8 |
The one line commit log, combined with the one line diff, seem pretty self explanatory to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 484e5d8
Would one or both of you @tcharding @Kixunil like to be a maintainer on this repo? I think our informal processes are fine to make sure that e.g. crypto stuff doesn't get merged without a crypto person reviewing. There's no reason to use Github to only allow a narrower set of reviewers. I'll go ahead and merge this with just your ACKs since we're not actually even enforcing the "maintainer must ACK" rule here.. |
Lol, oops, I actually screwed up this PR. I updated the secp-sys version but did not re-run the vendoring script to rename all the |
Yeah, I'd like to help maintain this. It's a key piece of the rust-bitcoin infrastructure so being more involved with it should help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 3373cc9
Thanks! Added you as a maintainer. |
Tagged, published, and yanked previous 0.9.x versions of secp-sys. |
Oops, crap, I need to update rust-secp along with rust-secp-sys, since this was actually a breaking change to rust-secp-sys. |
I'm willing to be a maintainer also. I'm not super confident with |
Bumped you from "Triage" to "Maintain". |
Fixes #669.
Needs backport.