Add from_u8_masked RecoveryId constructor
#778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an infallible constructor that takes a u8 and masks off the top 6 bits.
|
I was not 100% sure how to handle the 3, if it should be a case and then have an _ that cannot be reached? or as it is. |
tcharding
approved these changes
Jan 28, 2025
It's good like it is IMO. |
|
FYI the CI failure is unrelated. |
Thanks, I did look into it and couldn't see any reason for this PR causing it. |
Kixunil
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an infallible constructor that takes a u8 and masks off the top 6 bits.
Mentioned in rust-bitcoin/rust-bitcoin#3965