Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainance #17

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Maintainance #17

merged 5 commits into from
Aug 29, 2024

Conversation

vadixidav
Copy link
Member

@vadixidav vadixidav commented Aug 28, 2024

Closes #14, closes #16.

Remove patch version dependence. Note: This may violate semver, but is highly requested.

Use GAT lifetimes to simplify traits.

Rename traits and methods to be in-line with Rust idioms.

Use new dependency feature flag capabilities in Cargo to properly handle dependencies and alloc feature.

Simplify some implementations.

Fix up documentation to match changes.

Add some information to the README.

@vadixidav vadixidav merged commit 6b02eef into main Aug 29, 2024
3 checks passed
@tnibler
Copy link

tnibler commented Aug 29, 2024

Remove patch version dependence. Note: This may violate semver, but is highly requested.

I don't think it does (but correct me if I'm wrong), if the dependencies follow semver, they won't break public APIs in patch or minor versions (though I'm not sure how minor versions and 0.x numbers interact. So I think it's fine and this package is not doing anything wrong this way.

@xd009642
Copy link
Member

Honestly with the patch stuff cargo can actually update the patch version unless you've specified it as "=0.x.y" which stops it from updating. I think most people complaining about patch versions are trying to use versions with a different minor version (which won't get auto updated for a 0.x crate because it treats the minor like a major version then

@tnibler
Copy link

tnibler commented Aug 29, 2024

Ahh right my bad. Well I'd hope image and ndarray don't break their literal core types all that often so it'll probably be fine ;)

@vadixidav
Copy link
Member Author

It seems Cargo does allow the patch version to change by default, but according to the actual semver specification there is no guarantee of compatibility for any 0.x.y release. I think in the Rust community it is probably correct to simply assume that 0.x.y is essentially x - major and y - minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update image dependency Less strict dependencies
3 participants