Embedded hal 1.0.0 #213
Merged
Embedded hal 1.0.0 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eldruin any chance for a review :) Fwiw the minor version ofcourse needs to be bumped, unsure if you prefer that in the PR or to do it directly after merging |
eldruin
reviewed
Jul 1, 2024
| - run: cargo test --doc --target x86_64-unknown-linux-gnu | ||
| toolchain: 1.75 | ||
| - run: cargo build --lib --target x86_64-unknown-linux-gnu | ||
| - run: cargo doc --target x86_64-unknown-linux-gnu |
There was a problem hiding this comment.
Do the examples not build with Rust 1.75.0? If so, please rename this step "build with MSRV"
There was a problem hiding this comment.
Specifically embassy needs 1.79 at the moment; renamed now
eldruin
reviewed
Jul 1, 2024
The examples might require newer rust version based on the pac crate used; So for the MRSV test only build the actual library and documentation
stmf32f1xx doesn't yet support embedded-hal 1.0. Switch to embassy-stm32 as a pac provider, which can be used in both a sync and async setups. Unfortunately for blocking i2c support embassy git has to be used rather then a releaed version. Also for i2c move the expected configuration from PB8/PB9 to PB6/PB7 to avoid the needed for pin remapping, which embassy doesn't yet support on stm32f1xx chips
sjoerdsimons
force-pushed
the
embedded-hal-1.0.0
branch
from
412abba to
bad421a
Compare
|
@eldruin oh one favour; if your merge this can you use a fast-forward/merge commit rather then squashing the lot so the seperated commits are maintained :) |
eldruin
approved these changes
Jul 3, 2024
eldruin
merged commit 53039a8
into
rust-embedded-community:master
11 of 12 checks passed
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for helping out with SSD1306 development! Please:
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepPR description
This cherry-picks the embedded-hal-1.0.0 update from #207 and combined that with changing the various examples to use embassy-stm32 as the pac provider which implements embedded-hal-1.0 (stm32f1xx-hal does not yet).