support of default enum value #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
isdefault
branch
2 times, most recently
from
0200a15 to
0e1cb38
Compare
|
cc @Emilgardis |
Emilgardis
requested changes
Nov 22, 2023
src/generate/register.rs
Outdated
Comment on lines
1540
to
1548
| impl From<#pc> for #fty { | ||
| #[inline(always)] | ||
| fn from(variant: #pc) -> Self { | ||
| match variant { | ||
| #casts | ||
| } | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
this could also be a normal cast when the repr is fixed, or if this can't be fixed we should not use #[repr(u8)] and provide a Into impl
There was a problem hiding this comment.
I've removed repr, but I don't see what is wrong with From.
There was a problem hiding this comment.
you're right, I mentioned an Into in error
There was a problem hiding this comment.
is there a reason repr couldn't be used?
There was a problem hiding this comment.
when I started I thought it is impossible, but after refactoring and when you've asked the question it looks simple.
Now changes much smaller:
Emilgardis
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
This is usefull for (reading) fields like this:
For such fields changes look like:
