Adjusted zig cc judgment and avoided zigbuild errors(#1360) #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted is_zig_cc judgment and adjusted how supports_path_delimiter is handled.
NobodyXu
requested changes
Jan 11, 2025
Co-authored-by: Jiahao XU <[email protected]>
cargo fmt --check
NobodyXu
approved these changes
Jan 12, 2025
NobodyXu
requested changes
Jan 12, 2025
|
It seems that even clang itself may not support I would open another PR reverting changes to use that for clang and quickly cut another release |
NobodyXu
requested changes
Jan 12, 2025
|
One last change requested and once resolved I will merge this PR! |
This reverts commit a69d8bb.
NobodyXu
approved these changes
Jan 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted is_zig_cc judgment and adjusted how supports_path_delimiter is handled.