Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic in target-redirect when called with corrected name #2511

Merged
merged 1 commit into from
May 19, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented May 19, 2024

This fixed this panic / sentry error

called Option::unwrap() on a None value

coming from CrateDetails::from_matched_release.

It happens when the handler is called with different dash/underscores than the crate has.

@syphar syphar requested a review from a team as a code owner May 19, 2024 15:40
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label May 19, 2024
Copy link

sentry-io bot commented May 19, 2024

Sentry Issue: DOCS-RS-BACKEND-A8

@syphar syphar force-pushed the fix-panic-target-redirect branch from cc4eba0 to c60d3ee Compare May 19, 2024 16:03
@syphar syphar merged commit b4c3c5d into rust-lang:master May 19, 2024
7 checks passed
@syphar syphar deleted the fix-panic-target-redirect branch May 19, 2024 16:20
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels May 19, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants