Skip to content

Commit

Permalink
Check only (no longer test) at the MSRV
Browse files Browse the repository at this point in the history
Adjust CI so we only run a check the main crate at the MSRV (1.23),
running tests only at the MSRV of test dependencies. This allows us to
keep CI passing without increasing `glob`'s MSRV to match that of `libc`
(which since recently is 1.63.0) or other test dependencies.

Additionally, set `rust-version` in Cargo.toml.
  • Loading branch information
tgross35 committed Dec 28, 2024
1 parent 8eb644a commit 809f444
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
17 changes: 16 additions & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- stable
- beta
- nightly
- 1.23.0
- 1.63.0 # MSRV of test dependencies
os:
- macos-11
- windows-2022
Expand All @@ -33,3 +33,18 @@ jobs:
- name: Tests
run: cargo +${{ matrix.channel }} test --all

msrv:
name: "Check with the MSRV"
runs-on: ubuntu-22.04
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Update rust
run: |
rustup default 1.23.0
rustup update --no-self-update
- name: Tests
run: cargo check
3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ description = """
Support for matching file paths against Unix shell style patterns.
"""
categories = ["filesystem"]
rust-version = "1.23.0"

[dev-dependencies]
# FIXME: Replace it with `tempfile` once we bump up MSRV.
# FIXME: This should be replaced by `tempfile`
tempdir = "0.3"
doc-comment = "0.3"

0 comments on commit 809f444

Please sign in to comment.