Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a link to "how to add a feature gate" in the experimenting how-to #267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding a link to "how to add a feature gate" in the experimenting how-to #267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be756ac
Update experiment.md
jdonszelmann May 14, 2024
d444f46
Update src/how_to/experiment.md
jdonszelmann May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/how_to/experiment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ If you are an experienced Rust contributor who would like to start an experiment

* Write-up a description of the problem you are trying to solve and the general shape of the solution you want to work on. Discuss it on Zulip or elsewhere to find a **lang-team liaison**:
* The liaison is the connection to the lang-team. They can check in with you from time to time to see how the work is going and relay those updates to the lang-team (of course, you're always welcome to join meetings yourself too!). They can also help to discuss problems that arise.
* Once you've found a liaison, open a PR adding a new feature gate to the compiler and create an associated tracking issue.
* Once you've found a liaison, open a PR [adding a new feature gate to the compiler][adding] and create an associated tracking issue.
* The PR and tracking issue should include a write-up documenting the motivation and outline of what they are trying to achieve.
* The feature gate should be marked as 'experimental', so that users get warnings if they try to use it. This flag has to stay until an RFC is accepted, even if the implementation is in good shape.
* The lang-team liaison will "second" the PR, starting an FCP. Once the FCP completes, the PR can land and implementation work begins (always gated under the new feature gate).
Expand All @@ -19,6 +19,7 @@ If you are an experienced Rust contributor who would like to start an experiment
* When you feel the design is ready, you write an RFC as normal with your proposal. The goal of the experimentation period is simply to gain experience and information so that a better RFC can be authored.

[members]: https://www.rust-lang.org/governance/teams/lang
[adding]: https://rustc-dev-guide.rust-lang.org/implementing_new_features.html#stability-in-code

## Frequently asked questions

Expand Down