Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos: add CI using Buildomat #4010

Closed
wants to merge 1 commit into from

Conversation

sunshowers
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sunshowers
Copy link
Contributor Author

Oh sorry, meant to open this against my own branch. Closing for now.

@sunshowers sunshowers closed this Nov 6, 2024
@sunshowers sunshowers deleted the illumos-ci branch November 6, 2024 21:49
@tgross35
Copy link
Contributor

tgross35 commented Nov 7, 2024

Fyi there was a work in progress to add testing for another OS via vmactions, which also has Illumos. That would probably be preferable to adding another CI provider #3965

@tgross35
Copy link
Contributor

tgross35 commented Nov 7, 2024

I stand corrected, they don't have Illumos. Does Cirrus? As I understand it, they have everything that is available via GCP.

edit: er wait, is omnios illumos? If so then vmactions does have it https://github.com/vmactions/omnios-vm

@sunshowers
Copy link
Contributor Author

Thanks, I'll look at that. OmniOS might work!

@tgross35
Copy link
Contributor

tgross35 commented Nov 7, 2024

You know, we could use a target maintainer for Illumos (or at least a platform support page). It seems like you have been working with the platform a lot, any chance you would be willing to sign up for that? It's the zero commitment, just means that we have somebody specific to ping in the rare cases there are platform-specific questions.

If yes, just submit a rust-lang/rust PR. Copy TEMPLATE in https://github.com/rust-lang/rust/tree/master/src/doc/rustc/src/platform-support to illumos.md, update it (doesn't have to be very detailed), then update the table.

Solaris could use a platform page as well in case there is overlap there.

Cc @jclulow @pfmooney in case you might also be okay with being listed for illumos and/or solaris.

@jclulow
Copy link
Contributor

jclulow commented Nov 7, 2024

Thanks, I'll look at that. OmniOS might work!

We'll want to be careful using OmniOS, as they ship some extensions that are not in the base illumos bits.

@jclulow
Copy link
Contributor

jclulow commented Nov 7, 2024

You know, we could use a target maintainer for Illumos (or at least a platform support page). It seems like you have been working with the platform a lot, any chance you would be willing to sign up for that? It's the zero commitment, just means that we have somebody specific to ping in the rare cases there are platform-specific questions.

If yes, just submit a rust-lang/rust PR. Copy TEMPLATE in https://github.com/rust-lang/rust/tree/master/src/doc/rustc/src/platform-support to illumos.md, update it (doesn't have to be very detailed), then update the table.

Cc @jclulow @pfmooney in case you might also be okay with being listed for illumos and/or solaris.

Patrick and I have been acting in this capacity for years, but were only recently informed about the maintainer page stuff. There's a PR open right now to add a page: rust-lang/rust#132477

Solaris could use a platform page as well in case there is overlap there.

We've been separate OSes for 14 years, so there's not a great deal of overlap per se. I suspect folks from the Solaris team at Oracle would be best placed to handle their own page.

@tgross35
Copy link
Contributor

tgross35 commented Nov 7, 2024

We'll want to be careful using OmniOS, as they ship some extensions that are not in the base illumos bits.

It looks like OmniOS was added by request vmactions/solaris-vm#34 maybe worth asking for vanilla Illumos for the ecosystem as a whole (even if we wind up not using it here).

Patrick and I have been acting in this capacity for years, but were only recently informed about the maintainer page stuff. There's a PR open right now to add a page: rust-lang/rust#132477

Timing :) glad to hear it is in the works, thanks for the link! I think we really only started trying to fill out those pages in the past few months, most didn't exist until the past year.

Solaris could use a platform page as well in case there is overlap there.

We've been separate OSes for 14 years, so there's not a great deal of overlap per se. I suspect folks from the Solaris team at Oracle would be best placed to handle their own page.

👍 I just know the changes often come together to this repo but didn't know the background, thanks for the background.

@sunshowers
Copy link
Contributor Author

I have a mostly working OmniOS-based build at sunshowers#3 -- will send a PR once the upstream prereqs are met.

@sunshowers
Copy link
Contributor Author

We've had a closely look, and unfortunately OmniOS is different enough from upstream illumos that we don't feel confident. (For example, OmniOS has an inotify implementation that upstream doesn't, and it would be pretty easy to accidentally introduce inotify-related symbols to the illumos build.)

We'd like to not just throw illumos CI over the wall, and instead would prefer to fully support it and address issues in a timely manner. Buildomat is the system we use for our own CI at Oxide, so using that aligns with us.

Based on this, we believe that Buildomat is the way to go. What do you think?

@sunshowers
Copy link
Contributor Author

Put up a PR using Buildomat: #4023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants