Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add syslog macros LOG_MASK/LOG_UPTO #4238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SteveLauC
Copy link
Contributor

@SteveLauC SteveLauC commented Jan 12, 2025

Description

Adds syslog C macros to all UNIX targets

  1. LOG_MASK
  2. LOG_UPTO

They are re-implemented as Rust functions, and tests are added to ensure our Rust implementations have the same behavior as the C macro.

Sources

Link to the musl impl: https://github.com/bminor/musl/blob/61399d4bd02ae1ec03068445aa7ffe9174466bfd/include/syslog.h#L23-L24

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@SteveLauC
Copy link
Contributor Author

CI failure seems unrelated, it is due to a failed network call

@SteveLauC
Copy link
Contributor Author

Ok, now, the CI errors are really related to my patch, the wasi CIs failed because there is no sys/syslog.h header file, I am no WebAssembly expert, should I just simply disable the cc part and tests under these targets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants