Skip to content

Commit

Permalink
Update src/vec/vec-zsts.md
Browse files Browse the repository at this point in the history
Co-authored-by: Jon Bauman <[email protected]>
  • Loading branch information
pwbh and baumanj authored Nov 21, 2024
1 parent 18c8a83 commit 94951ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/vec/vec-zsts.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ impl<T> DoubleEndedIterator for RawValIter<T> {

And that's it. Iteration works!

One last thing that we need to take into account is that now when our vec gets dropped it deallocates the memory that was allocated during the time our vec was alive. With ZSTs we did not allocate any memory, and infact we never do. So right now we have unsoundness in our code where we still try deallocate a `NonNull::dangling()` ptr that we use to simulate the ZST in our vec, This means that we would cause an undefined behaviour if we try to deallocate something that we never allocated (obviously and for the right reasons). Lets fix tha, in our raw_vec we are going to tweak our Drop trait and check that we deallocate only types that are sized.
One last thing that we need to take into account is that now when our vec gets dropped it deallocates the memory that was allocated during the time our vec was alive. With ZSTs we did not allocate any memory, and in fact we never do. So right now we have unsoundness in our code where we still try deallocate a `NonNull::dangling()` ptr that we use to simulate the ZST in our vec, This means that we would cause undefined behavior if we try to deallocate something that we never allocated (obviously and for the right reasons). To fix that, in our `RawVec` we are going to tweak our `Drop` trait and check that we deallocate only types that are sized.

```rust,ignore
impl<T> Drop for RawVec<T> {
Expand Down

0 comments on commit 94951ed

Please sign in to comment.