Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: complete raw, const keyword #18952

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat: complete raw, const keyword #18952

merged 2 commits into from
Jan 16, 2025

Conversation

lh123
Copy link
Contributor

@lh123 lh123 commented Jan 16, 2025

  1. complete raw, const keyword
  2. parse let _ = &raw foo better

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2025
@lh123 lh123 force-pushed the add-raw-keyword-complete branch from 7cb1ba5 to 9809143 Compare January 16, 2025 10:28
Veykril
Veykril reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test caseto add would be &mut $0 (to verify we don't complete raw here)

@Veykril Veykril added this pull request to the merge queue Jan 16, 2025
@Veykril
Copy link
Member

Veykril commented Jan 16, 2025

Thanks!

Merged via the queue into rust-lang:master with commit 903bc81 Jan 16, 2025
9 checks passed
@lh123 lh123 deleted the add-raw-keyword-complete branch January 17, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lh123 @Veykril @rustbot