Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor clippy lints #3075

Merged
merged 1 commit into from
Feb 1, 2025
Merged

A few minor clippy lints #3075

merged 1 commit into from
Feb 1, 2025

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jan 9, 2025

  • Fix unnested_or_patterns
  • Do a few match_same_arms, but keep the lint disabled

"test_header!(header_{func}, {:?});",
entry.path(),
)
// TODO: file_is_cpp() in bindgen/lib.rs checks for hpp,hxx,hh, and h++ - should this be consistent?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe but this is test only so...

}
FunctionKind::Method(
MethodKind::Destructor |
MethodKind::VirtualDestructor { .. },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta say I find it more readable before this change, but no huge deal I guess :)

@emilio emilio added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
* Fix `unnested_or_patterns`
* Do a few `match_same_arms`, but keep the lint disabled
@emilio emilio added this pull request to the merge queue Feb 1, 2025
Merged via the queue into rust-lang:main with commit 4de3ada Feb 1, 2025
34 checks passed
@nyurik nyurik deleted the lints branch February 1, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants