Fix obfuscated_if_else suggestion on left side of a binary expr
#14124
+130
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
blyxyas
requested changes
Feb 8, 2025
There was a problem hiding this comment.
Could you add the //~ ui_test annotations?
There was a problem hiding this comment.
Should be ok now
An `if … { … } else { … }` used as the left operand of a binary
expression requires parentheses to be parsed as an expression.
samueltardieu
force-pushed
the
push-sxuslxyxnzlz
branch
from
dd51e96 to
ac0a11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
if … { … } else { … }used as the left operand of a binary expression requires parentheses to be parsed as an expression.Fix #11141
changelog: [
obfuscated_if_else]: fix bug in suggestion by issuing required parentheses around the left side of a binary expression