UI test cleanup: Extract lint from methods.rs test #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously duplicated in rust-lang#3605
phansch
force-pushed
the
method_rs_cleanup
branch
from
65a9c34 to
0c54913
Compare
phansch
added
the
S-waiting-on-author
flip1995
reviewed
Jan 2, 2019
phansch
added
S-waiting-on-review
flip1995
reviewed
Jan 3, 2019
| @@ -22,6 +24,9 @@ | |||
| clippy::useless_format | |||
| )] | |||
|
|
|||
| #[macro_use] | |||
| extern crate option_helpers; | |||
There was a problem hiding this comment.
Is this extern crate necessary? Aren't we using the 2018 edition in the tests? Or do we need this because of the aux-build of compiletest-rs?
use option_helpers::opt_map;should be possible.
There was a problem hiding this comment.
Currently it's necessary yes. I think it's an issue with compiletest: Manishearth/compiletest-rs#150
|
@bors r+ |
|
📌 Commit a5d3f37 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 4, 2019
UI test cleanup: Extract lint from methods.rs test Extracts the `result_map_unwrap_or_else` lint into a separate test file. This also extracts the `IteratorFalsePositives` struct and impl into `auxiliary/option_helpers.rs`. cc #2038
|
💔 Test failed - status-travis |
flip1995
added
S-waiting-on-author
|
This should re- |
|
@bors r=flip1995 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a5d3f37 has been approved by |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jan 5, 2019
UI test cleanup: Extract lint from methods.rs test Extracts the `result_map_unwrap_or_else` lint into a separate test file. This also extracts the `IteratorFalsePositives` struct and impl into `auxiliary/option_helpers.rs`. cc #2038
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jan 5, 2019
UI test cleanup: Extract lint from methods.rs test Extracts the `result_map_unwrap_or_else` lint into a separate test file. This also extracts the `IteratorFalsePositives` struct and impl into `auxiliary/option_helpers.rs`. cc #2038
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the
result_map_unwrap_or_elselint into a separate test file.This also extracts the
IteratorFalsePositivesstruct and impl intoauxiliary/option_helpers.rs.cc #2038