Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve panic message on "Found multiple rlibs" error in compile-test #7380

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

popzxc
Copy link
Contributor

@popzxc popzxc commented Jun 20, 2021

Related to #7343

When I first met this error I was pretty much confused, so I thought it may be a good idea to:

  • Give a hint on what to do to users that don't want to dig into specifics and just want to quickly resolve the issue.
  • Give a link for those who are interested in details.

Old appearance:

Screenshot 2021-06-20 at 08 30 34

New appearance:

Screenshot 2021-06-20 at 08 32 18

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: none

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 20, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 21, 2021

cargo clean will do nothing in rust-lang/rust. Can you suggest "Remove the stageN-tools directory" instead when RUSTC_BOOTSTRAP is set in the environment? (or any other way of detecting x.py; BOOTSTRAP_PYTHON should work too)

@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jun 21, 2021

📌 Commit 310a204 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jun 21, 2021

⌛ Testing commit 310a204 with merge d3327bd...

@bors
Copy link
Contributor

bors commented Jun 21, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d3327bd to master...

@bors bors merged commit d3327bd into rust-lang:master Jun 21, 2021
@popzxc popzxc deleted the compile-test-helper branch June 21, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants