Add note about running clippy ci during the release process #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Mark-Simulacrum
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Hm, I wish we didn't need a separate command for this. Maybe we can push to replace x.py check with x.py clippy? Is the latter always a superset?
This is probably best commented elsewhere...
Edit: started a thread here - https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/clippy.20instead.20of.20check.20automatically.3F
|
Let's merge this in the meantime, we can always replace this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rust-lang/rust#132649 got merged (thanks @klensy!) we should add a step to the master update recommending to run the command and fix the lints it points out, to avoid the failure happening in CI.
r? @Mark-Simulacrum