Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Add workaround for index out of bounds on escaping substs #312

Closed
wants to merge 1 commit into from

Conversation

dario23
Copy link
Contributor

@dario23 dario23 commented May 28, 2022

See #188 for some discussion. The proper fix would probably be a bigger
refactoring endeavor, but this avoids the index out of bounds access for
now.

See rust-lang#188 for some discussion. The proper fix would probably be a bigger
refactoring endeavor, but this avoids the index out of bounds access for
now.
@JohnTitor
Copy link
Member

The failure is:

rust-semverver failed to produce the expected result
=== Expected output ===
version bump: 1.0.0 -> (patch) -> 1.0.1
=== End of expected output ===
=== Actual output ===
version bump: 1.0.0 -> (breaking) -> 2.0.0
error: breaking changes in `b`
  --> infer/new.rs:13:1
   |
13 | pub fn b() -> a::Opq {
   | ^^^^^^^^^^^^^^^^^^^^
   |
   = warning: type error: expected struct `old::a::Klm`, found struct `new::a::Opq` (breaking)

error: aborting due to previous error
=== End of actual output ===

We now catch one more case? Nice.

@JohnTitor
Copy link
Member

Closing as we're going to deprecate this crate, thank you for suggesting the change anyway!

@JohnTitor JohnTitor closed this Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants