-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: fully rely on RUSTC_WRAPPER #127682
Conversation
This comment has been minimized.
This comment has been minimized.
Turns out even our own libc crate doesn't properly wrap its rustc invocations.^^ I guess I did not hit this locally as the build script was already cached. |
@rustbot blocked |
This comment was marked as outdated.
This comment was marked as outdated.
ad9308c
to
946ee4f
Compare
Locally a check-build passes now, let's see what CI says... |
This comment has been minimized.
This comment has been minimized.
I guess I still had cached build script results somewhere. The next offender is: field-offset. It uses |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
This comment has been minimized.
This comment has been minimized.
d4462b4
to
77d269a
Compare
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
This comment has been minimized.
This comment has been minimized.
Blocked on stepancheg/rust-protobuf#735. |
@rust-lang/rust-analyzer not sure if you have some sort of direction relationship with your dependencies, but if you, do, it'd be good if you could take a look at this. I am trying to do a cleanup in bootstrap, and the very last holdout (well, it seems to be the last holdout, it's tricky to be sure) is a problem with one indirect dependency of rust-analyzer: the |
@RalfJung Ah, I might be able to make a few things happen. Lemme ask around. |
|
That should be fine though since it's a semver-compatible update. |
Oh wtf they use a |
|
It's not a breaking change to do a semver-compatible update of public API types, is it? Next blocker: sourcegraph/scip#284 |
77d269a
to
4b05169
Compare
This comment has been minimized.
This comment has been minimized.
scip got updated, now we're just waiting for rust-lang/rust-analyzer#18315 to be synced into the rustc repo. :) |
Once we deal with the fallout from #123951 :-). |
Ready. |
4b05169
to
024677f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
What the heck is going on here?
Now rustc is triple-wrapped?^^ Seems to be some problem with the clippy logic? Cc @rust-lang/clippy |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Hm, compiletest seems to require a single rustc binary, it doesn't support wrappers. This rabbit hole is too deep, I have to stop here. |
Clippy uses |
I resolved the clippy issue, it's compiletest that stumped me.
|
With rust-lang/cargo#13659, cargo now respects RUSTC_WRAPPER for all rustc invocations. That means we can finally remove the hack where we set our wrapper as both RUSTC and RUSTC_WRAPPER.
There could still be build scripts that fail to respect RUSTC_WRAPPER, but then we should fix those before they become a rustc dependency.
Fixes #128383