-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add String::replace_first
and String::replace_last
#134316
base: master
Are you sure you want to change the base?
Conversation
Rebased by zachs18. Co-authored-by: zachs18 <[email protected]>
Also line-wrap doc-comment.
I don't think I see any libs-api feedback on the other thread, and that is from a while back anyway. Could you file an ACP for this at https://github.com/rust-lang/libs-team/issues? |
These methods would be convenient but I feel like they should probably come with an in-place |
This comment has been minimized.
This comment has been minimized.
ACP opened: rust-lang/libs-team#506 @rustbot label S-waiting-on-ACP I added |
☔ The latest upstream changes (presumably #135286) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebase of #97977 (cc @WilliamVenner)
The intra-doc link to
str::replacen
is a direct url-based link tostr::replacen
instd
's docs to work around #98941. This means that when building onlyalloc
's docs (and notstd
's), it will be a broken link. There is precedent for this e.g. incore::hint::spin_loop
which links tostd::thread::yield_now
using a url-based link and thus is a dead link when only buildingcore
's docs.