Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: split x86_64-msvc job using windows 2025 #135632

Merged
merged 1 commit into from
Jan 21, 2025
Merged

CI: split x86_64-msvc job using windows 2025 #135632

merged 1 commit into from
Jan 21, 2025

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Jan 17, 2025 •
edited
Loading

windows-2025 seems to fix the flakiness discribed in #127883 — This PR never failed a bors try.
This PR also removes the large runner by splitting it into two free runners, addressing rust-lang/infra-team#189 🥳

Too good to be true? Let's see! My suggestion is to merge this PR and observe how it behaves in the auto branch in the public dashboard over the following weeks.

Additional context

I discussed this change in Zulip as well.

If you want to see a similar PR to this one where x86_64-msvc on windows 2022 fails in CI consistently, see #135483 (comment)

r? @Kobzol

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: dist-x86_64-msvc

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 17, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
e8d81bc 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit b563fc9 with merge e8d81bc...

@bors
Copy link
Contributor

bors commented Jan 17, 2025

☀️ Try build successful - checks-actions
Build commit: e8d81bc (e8d81bcb17fe0d757c6e24a533de6f6e49bc6b3a)

@marcoieni
Copy link
Member Author

good. It worked. Trying again to see if we were just lucky.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
f5b8f99 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit b563fc9 with merge f5b8f99...

@bors
Copy link
Contributor

bors commented Jan 17, 2025

☀️ Try build successful - checks-actions
Build commit: f5b8f99 (f5b8f99638fd7df176fd8a47a84352b50ea671c3)

@marcoieni
Copy link
Member Author

Wooo. Let's test it again.

@bors try

@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit b563fc9 with merge 42acc46...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
42acc46 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: 42acc46 (42acc46e5861e3067f97de2d155574bc1032c422)

@marcoieni
Copy link
Member Author

marcoieni commented Jan 18, 2025 •
edited
Loading

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
42503c0 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge 42503c0...

@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: 42503c0 (42503c0eff91edd3c590358e274d0f112bb4c04e)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge dcf45f7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
dcf45f7 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: dcf45f7 (dcf45f7f7db20f8b518ace2afd346e1e93b44a7e)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge 6ee2817...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
6ee2817 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: 6ee2817 (6ee28179cf84c7973e4bec5680bd45bddb931a5a)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge 0697d1c...

@bors
Copy link
Contributor

bors commented Jan 19, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 19, 2025
@marcoieni
Copy link
Member Author

From my understanding, this should be a flaky error.
I will run this job in the bors try to confirm.

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
53ba4de 
…<try>

CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: dist-x86_64-msvc
@bors
Copy link
Contributor

bors commented Jan 19, 2025

⌛ Trying commit 242b0e3 with merge 53ba4de...

@bors
Copy link
Contributor

bors commented Jan 19, 2025

☀️ Try build successful - checks-actions
Build commit: 53ba4de (53ba4de9d1f3e6cbdaef40d34463b16820572828)

@marcoieni
Copy link
Member Author

Looks good, I'll wait for a reviewer to bors retry 👍

@Kobzol
Copy link
Contributor

Kobzol commented Jan 20, 2025

@bors retry

@bors
Copy link
Contributor

bors commented Jan 20, 2025

⌛ Trying commit 242b0e3 with merge 122ecfc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
122ecfc 
…<try>

CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: dist-x86_64-msvc
@bors
Copy link
Contributor

bors commented Jan 20, 2025

☀️ Try build successful - checks-actions
Build commit: 122ecfc (122ecfc385f6e024e50ffb8a5fe758040c5b6782)

@marcoieni
Copy link
Member Author

Shouldn't bors retry also "approve" the PR if the try build succeeds? 🤔

@Kobzol
Copy link
Contributor

Kobzol commented Jan 20, 2025

bors retry shouldn't actually do anything with a try build, it should just reapprove. But maybe it behaves differently if you start a try build in the meantime.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 20, 2025

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jan 20, 2025

📌 Commit 242b0e3 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2025
@bors
Copy link
Contributor

bors commented Jan 21, 2025

⌛ Testing commit 242b0e3 with merge ebbe638...

@bors
Copy link
Contributor

bors commented Jan 21, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing ebbe638 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 21, 2025
@bors bors merged commit ebbe638 into rust-lang:master Jan 21, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 21, 2025
@marcoieni marcoieni mentioned this pull request Jan 21, 2025
Open
4 tasks
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ebbe638): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.9%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.9% [2.0%, 7.3%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 3.9% [2.0%, 7.3%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.449s -> 763.258s (-0.16%)
Artifact size: 326.06 MiB -> 326.07 MiB (0.00%)

@RalfJung RalfJung mentioned this pull request Jan 21, 2025
Merged
This was referenced Jan 27, 2025
Merged
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
7 participants
@marcoieni @bors @ChrisDenton @Kobzol @rust-log-analyzer @rust-timer @rustbot