Fix ICE in resolve
#32813
Closed
Fix ICE in resolve
#32813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -332,6 +332,7 @@ impl<'a> ::ModuleS<'a> { | |||
|
|
|||
| fn define_in_glob_importers(&self, name: Name, ns: Namespace, binding: &'a NameBinding<'a>) { | |||
| if !binding.defined_with(DefModifiers::PUBLIC | DefModifiers::IMPORTABLE) { return } | |||
| let _resolutions = self.resolutions.borrow(); | |||
There was a problem hiding this comment.
A comment here, preferably one citing some example source, would be fantastic. e.g. I can kind of guess why this makes sense, but it's not at all obvious.
There was a problem hiding this comment.
Will do. This is actually somewhat of a hack -- see #32814
|
Closing in favor of #32814. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #32797, a regression caused by a bug in which we try to mutate a borrowed
RefCell. The bug was introduced in #32328 (second to last commit).r? @nikomatsakis