-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed error explanation for E0501 #33294
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
the closure goes out of scope. | ||
|
||
Example of erroneous code: | ||
```compile_fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need an extra line before the code block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
@GuillaumeGomez - request for more critiques. |
capturing. | ||
|
||
Example of erroneous code: | ||
```compile_fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing empty line before this one.
It's globally good except for the few nits I reported. Also, could try to rewrite a bit the initial explanation please? Like I said, a lot of words are repeated and it makes the reading a bit harder than necessary. Thanks! |
I think I took care of the repetition problem. Let me know if it's still not up to snuff! |
The new explanation is good. Just remaining a nit to fix (the missing empty line) and we're good to merge! Once fixed, don't forget to squash your commits please. |
ccc5773
to
7004b97
Compare
Alright. I squashed the commits after fixing the missing empty line. Right after pushing, I noticed another missing newline and had to do it again. 😦 |
All good. Thanks for your work! r=me @steveklabnik |
@bors: r=GuillaumeGomez rollup |
📌 Commit 3f49920 has been approved by |
Add detailed error explanation for E0501 r? @GuillaumeGomez Bring on the nits!
Add detailed error explanation for E0501 r? @GuillaumeGomez Bring on the nits!
#32777
r? @GuillaumeGomez
Bring on the nits!