Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation for E0592 #61822

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Add explanation for E0592 #61822

merged 3 commits into from
Jun 18, 2019

Conversation

JohnTitor
Copy link
Member

This is a part of #61137

r? @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2019
Centril
Centril reviewed Jun 14, 2019
View reviewed changes
src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
GuillaumeGomez
GuillaumeGomez requested changes Jun 14, 2019
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add comments in your code example. It helps the reading.

src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_typeck/error_codes.rs Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member

Except for the sentence I'm not sure about, it looks good to me now. Can someone else confirm please? (an english native if possible)

GuillaumeGomez
GuillaumeGomez approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a confirmation for a sentence needed if possible but otherwise looks good to me!

@Centril
Copy link
Contributor

Centril commented Jun 17, 2019

@bors r=GuillaumeGomez,Centril rollup

@bors
Copy link
Contributor

bors commented Jun 17, 2019

📌 Commit 3d5ef11 has been approved by GuillaumeGomez,Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2019
@bors
Copy link
Contributor

bors commented Jun 18, 2019

⌛ Testing commit 3d5ef11 with merge 0376941...

bors added a commit that referenced this pull request Jun 18, 2019
@bors
Auto merge of #61822 - JohnTitor:add-long-e0592, r=GuillaumeGomez,Cen…
0376941 
…tril

Add explanation for E0592

This is a part of #61137

r? @GuillaumeGomez
@bors
Copy link
Contributor

bors commented Jun 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: GuillaumeGomez,Centril
Pushing 0376941 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 18, 2019
@bors bors merged commit 3d5ef11 into rust-lang:master Jun 18, 2019
@JohnTitor JohnTitor deleted the add-long-e0592 branch June 18, 2019 15:18
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 25, 2019
Closed
100 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohnTitor @GuillaumeGomez @Centril @bors @rust-highfive