-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E0183] Add missing error code explanation #63022
Conversation
This is part of the ongoing work for #61137
Some changes occurred in diagnostic error codes |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, but not in the expected order. 😄 So, beyond my small fix requests, the global format of the explanation isn't "good". Steps:
- First you should state what the error.
- Followed then by "Erroneous code example:".
- Then comes the erroneous code example.
- Here goes the explanation of the error and how to solve it.
- Here comes the fixed code example from
3.
.
Also, please remember that those long error explanations are not only rendered into html but can also be seen into terminals when running rustc --explain [ERROR CODE]
(which explains why I asked you to put empty lines before code blocks).
I tried to gather info from the surrounding errors about the format to follow but I wasn't really able. |
I was wondering tho, what's the actual error? When is this error emitted? Using |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@Karrq That's part of why we ask to show the error. It also helps to check that the error is still emitted. It's however a bit surprising that the error doesn't show up... I can only recommend you to take a look at how it's emitted in the compiler (generally it's not very complicated). Look for the error code directly. If you still can't figure out, maybe you can give a try to another error code? |
@GuillaumeGomez I was able to figure out when the error is supposed to be emitted: Upon digging more (searching I believe there's no way from us to trigger this specific error, yet. Nevertheless, now that I know what's supposed to emit this error I'll update the description accordingly in the next commit. |
According to the unstable book, From what I gathered:
|
previous guidelines followed regarding formatting
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Ping from triage: @Karrq and @GuillaumeGomez any updates on this? |
I'm waiting on @Karrq. :) |
Doesn't look like that to me. I added 2 comments to the issue and a commit based on those comments. Haven't received a review/reply since. I see that github says that there are changes requested, but I can't figure out how to remove that since the changes have happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated
So, @GuillaumeGomez, as I commented previously there are some concerns that I think need to be discussed. I'd like to know what you are waiting on me for. Is is the build errors for the pipeline? If that's so I'd like some guidance on how to resolve them, since I'm not able to figure out why they are being generated in the first place. |
The error index aren't generated automatically, when you generate a new compiler error, you create a new error index alongside and normally you also provide the long error explanation (and a test where the error is checked to be emitted). It's possible that the path to the error isn't possible anymore and then you should just try your luck with another error code (one which has a test). |
ping from triage @Karrq, any updates on this? Thanks for your time! |
Unfortunately I've been very busy recently and couldn't really take a look at the error index, but since the error itself doesn't seem to be able to be emitted I don't think there's much more I can do |
From triage: |
I'll need to check later in the future. |
Ping from triage: |
Ping from triage: @Karrq @GuillaumeGomez any updates on this? |
Ping from Triage: @Karrq we are closing this due to inactivity. However, when you have updates, please re-open. Thank you for the PR. |
This is the continuation of #61225
CC #61137
Let me know if there's anything that needs change