Code

Update Clippy#88615

Code

Merged

bors merged 141 commits intorust-lang:masterrust-lang/rust:masterfrom flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboardSep 9, 2021

+4,153-1,296

Commits

Commits on Aug 10, 2021

• Update suggestion in case of index for unnecessary_operation lint

  F3real

  committed
  ede977c

  Copy full SHA for ede977c

Commits on Aug 12, 2021

• Bless clippy tests.

  m-ou-se

  committed
  8e563b5

  Copy full SHA for 8e563b5

• Merge commit '7bfc26ec8e7a454786668e7e52ffe527fc649735' into clippyup

  flip1995

  committed
  1ad5464

  Copy full SHA for 1ad5464

• Rollup merge of rust-lang#87885 - m-ou-se:edition-guide-links, r=rylev

  Show description for fd5427b
  GuillaumeGomez

  authored
  fd5427b

  Copy full SHA for fd5427b

• Updated lint message for rc_mutex

  xFrednet

  committed
  09b7745

  Copy full SHA for 09b7745

• Use avoid_breaking_exported_api for types module lints

  Show description for 206741b
  xFrednet

  committed
  206741b

  Copy full SHA for 206741b

• Update type UI tests to use private items

  xFrednet

  committed
  c02dcd5

  Copy full SHA for c02dcd5

• Auto merge of rust-lang#7560 - xFrednet:7289-configuration-for-every-type-lint, r=camsteffen

  Show description for b4d76b4
  bors

  committed
  b4d76b4

  Copy full SHA for b4d76b4

Commits on Aug 13, 2021

• Auto merge of rust-lang#87954 - flip1995:clippyup, r=Manishearth

  Show description for 456e48f
  bors

  committed
  456e48f

  Copy full SHA for 456e48f

• Add false positive test for iterator method

  dswij

  committed
  e9f56f9

  Copy full SHA for e9f56f9

• Fix false positive on filter_next

  dswij

  committed
  91b598a

  Copy full SHA for 91b598a

• Auto merge of rust-lang#7562 - dswij:filter-next-false-positive, r=xFrednet

  Show description for 7c5487d
  bors

  committed
  7c5487d

  Copy full SHA for 7c5487d

• move Constness into TraitPredicate

  fee1-dead

  committed
  80bff87

  Copy full SHA for 80bff87

Commits on Aug 14, 2021

• Downgrade option_if_let_else to nursery

  dtolnay

  committed
  3c8eaa8

  Copy full SHA for 3c8eaa8

• Improve manual_map and map_entry

  Show description for 4838c78
  Jarcho

  committed
  4838c78

  Copy full SHA for 4838c78

• Improve manual_map

  Show description for 251dd30
  Jarcho

  committed
  251dd30

  Copy full SHA for 251dd30

• Fix tracking of which locals would need to be captured in a closure.

  Show description for 9500974
  Jarcho

  committed
  9500974

  Copy full SHA for 9500974

• Improve doc for can_move_expr_to_closure_no_visit

  Jarcho

  committed
  5e4d8b4

  Copy full SHA for 5e4d8b4

• update stderr messages

  Jarcho

  committed
  10c0460

  Copy full SHA for 10c0460

Commits on Aug 15, 2021

• Auto merge of rust-lang#7568 - dtolnay-contrib:ifletelse, r=llogiq

  Show description for 5449e23
  bors

  committed
  5449e23

  Copy full SHA for 5449e23

• Introduce hir::ExprKind::Let - Take 2

  c410-f3r

  committed
  b97d4c0

  Copy full SHA for b97d4c0

Commits on Aug 16, 2021

• Lintcheck always copies in a fresh crate when provided with a crate path

  Show description for 997ddbb
  rukai

  committed
  997ddbb

  Copy full SHA for 997ddbb

• Auto merge of rust-lang#7521 - rukai:fix_lintcheck_local_path_handling, r=camsteffen

  Show description for d4e2fca
  bors

  committed
  d4e2fca

  Copy full SHA for d4e2fca

• Use each_binding_or_first in capture_local_usage

  Jarcho

  committed
  f0444d7

  Copy full SHA for f0444d7

• Auto merge of rust-lang#7531 - Jarcho:manual_map_7413, r=camsteffen

  Show description for 3f0c977
  bors

  committed
  3f0c977

  Copy full SHA for 3f0c977

• Uplift the invalid_atomic_ordering lint from clippy to rustc

  Show description for 295225b
  

  thomcc

  authored and

  jyn514

  committed
  295225b

  Copy full SHA for 295225b

• Auto merge of rust-lang#84039 - jyn514:uplift-atomic-ordering, r=wesleywiser

  Show description for d9c3f0d
  bors

  committed
  d9c3f0d

  Copy full SHA for d9c3f0d

• Add false positive test for manual_flatten

  Show description for 711c5cb
  dswij

  committed
  711c5cb

  Copy full SHA for 711c5cb

• Check if let expr usage in manual_flatten

  Show description for a09bc1b
  dswij

  committed
  a09bc1b

  Copy full SHA for a09bc1b

• Auto merge of rust-lang#7566 - dswij:manual-flatten-use, r=xFrednet

  Show description for 983e5b8
  bors

  committed
  983e5b8

  Copy full SHA for 983e5b8

• Add for_each_local_usage. Switch LocalUsedVisitor to a function.

  Jarcho

  committed
  8cf6dae

  Copy full SHA for 8cf6dae

• Add lint manual_split_once

  Jarcho

  committed
  a7f376f

  Copy full SHA for a7f376f

• Update docs for manual_split_once

  Jarcho

  committed
  aab3267

  Copy full SHA for aab3267

• clippy: Fix format_args expansion parsing

  camsteffen

  committed
  d5e51db

  Copy full SHA for d5e51db

• Fix option_if_let_else

  Show description for 8b3ca9a
  Jarcho

  committed
  8b3ca9a

  Copy full SHA for 8b3ca9a

• Update docs for expl_impl_clone_on_copy. Bug was fixed in 879fa5c9721c89c27be6a9db5f51d935a51f549b1~

  Jarcho

  committed
  3c6c7d5

  Copy full SHA for 3c6c7d5

Commits on Aug 17, 2021

• Auto merge of rust-lang#7574 - Jarcho:expl_impl_clone_on_copy_doc, r=giraffate

  Show description for c50e6e4
  bors

  committed
  c50e6e4

  Copy full SHA for c50e6e4

• Small documentation update for the new metadata_collector

  xFrednet

  committed
  c01aa64

  Copy full SHA for c01aa64

• Auto merge of rust-lang#7578 - xFrednet:7172-update-some-docs, r=camsteffen

  Show description for cde7e6b
  bors

  committed
  cde7e6b

  Copy full SHA for cde7e6b

• Auto merge of rust-lang#7565 - Jarcho:manual_split_once, r=llogiq

  Show description for 1fc1aee
  bors

  committed
  1fc1aee

  Copy full SHA for 1fc1aee

Commits on Aug 18, 2021

• remove box_syntax uses from cranelift and tools

  

  hellow554

  authored and

  est31

  committed
  4123fed

  Copy full SHA for 4123fed

Commits on Aug 19, 2021

• Fix clippy let expressions fallout

  camsteffen

  committed
  ae02282

  Copy full SHA for ae02282

• introduce a Coerce predicate

  

  nikomatsakis

  authored and

  Mark-Simulacrum

  committed
  5fec618

  Copy full SHA for 5fec618

Commits on Aug 21, 2021

• cleanup: Span::new -> Span::with_lo

  petrochenkov

  committed
  cd4bf7f

  Copy full SHA for cd4bf7f

Commits on Aug 22, 2021

• Auto merge of rust-lang#88163 - camsteffen:collapsible-match-fix, r=Manishearth

  Show description for e5fe462
  bors

  committed
  e5fe462

  Copy full SHA for e5fe462

• Fix typos “a”→“an”

  steffahn

  committed
  c860718

  Copy full SHA for c860718

• Fix more “a”/“an” typos

  steffahn

  committed
  21da42c

  Copy full SHA for 21da42c

• Fix typos “an”→“a” and a few different ones that appeared in the same search

  steffahn

  committed
  8b6529e

  Copy full SHA for 8b6529e

• Rollup merge of rust-lang#88211 - petrochenkov:withhilo, r=jyn514

  Show description for 5868e28
  GuillaumeGomez

  authored
  5868e28

  Copy full SHA for 5868e28

Commits on Aug 23, 2021

• Add new lints negative_feature_names and redundant_feature_names

  Labelray

  committed
  0a021d5

  Copy full SHA for 0a021d5

• Auto merge of rust-lang#7539 - Labelray:master, r=camsteffen

  Show description for 22606e7
  bors

  committed
  22606e7

  Copy full SHA for 22606e7

• Remove stderr limit

  camsteffen

  committed
  68b4a43

  Copy full SHA for 68b4a43

• Auto merge of rust-lang#7593 - camsteffen:remove-stderr-limit, r=Manishearth

  Show description for 6ca0007
  bors

  committed
  6ca0007

  Copy full SHA for 6ca0007

• Move branches_sharing_code to nursery

  camsteffen

  committed
  2f73776

  Copy full SHA for 2f73776

• Rollup merge of rust-lang#88230 - steffahn:a_an, r=oli-obk

  Show description for 4c847c0
  m-ou-se

  authored
  4c847c0

  Copy full SHA for 4c847c0

• Auto merge of rust-lang#7595 - camsteffen:branches-sharing-nursery, r=Manishearth

  Show description for 15b1c6f
  bors

  committed
  15b1c6f

  Copy full SHA for 15b1c6f

• Auto merge of rust-lang#83302 - camsteffen:write-piece-unchecked, r=dtolnay

  Show description for 72df99a
  bors

  committed
  72df99a

  Copy full SHA for 72df99a

Commits on Aug 24, 2021

• redundant_allocation: fix 7487

  lengyijun

  committed
  641be55

  Copy full SHA for 641be55

• Auto merge of rust-lang#7592 - lengyijun:redundant_allocation, r=camsteffen

  Show description for 87c6f32
  bors

  committed
  87c6f32

  Copy full SHA for 87c6f32

• Add module_style lint to restriction

  Show description for 31738b1
  DevinR528

  committed
  31738b1

  Copy full SHA for 31738b1

Commits on Aug 25, 2021

• Auto merge of rust-lang#7453 - F3real:assume_function_calls_have_side_effect, r=flip1995

  Show description for 3051773
  bors

  committed
  3051773

  Copy full SHA for 3051773

• Updated issue templates(formatting and rustbot label reference)

  xFrednet

  committed
  10909ae

  Copy full SHA for 10909ae

• Auto merge of rust-lang#7543 - DevinR528:disallowed-mod, r=Manishearth

  Show description for de80188
  bors

  committed
  de80188

  Copy full SHA for de80188

Commits on Aug 26, 2021

• require a tcx for TypeVisitor

  lcnr

  committed
  4d627fc

  Copy full SHA for 4d627fc

• make unevaluated const substs optional

  lcnr

  committed
  19d1fe2

  Copy full SHA for 19d1fe2

• add tcx to fn walk

  lcnr

  committed
  b1786f6

  Copy full SHA for b1786f6

• update TypeFlags to deal with missing ct substs

  lcnr

  committed
  afd892a

  Copy full SHA for afd892a

• Set applicability of needless_collect to MaybeIncorrect

  flip1995

  committed
  c6e4202

  Copy full SHA for c6e4202

• Update common tool docs on type implement trait check

  Show description for 86e92c0
  dswij

  committed
  86e92c0

  Copy full SHA for 86e92c0

• Update doc/common_tools_writing_lints.md

  Show description for f0cb8a7
  

  dswij

  and

  xFrednet

  authored
  f0cb8a7

  Copy full SHA for f0cb8a7

• Auto merge of rust-lang#7583 - dswij:match-trait-docs, r=xFrednet

  Show description for 387dbd7
  bors

  committed
  387dbd7

  Copy full SHA for 387dbd7

• Auto merge of rust-lang#7602 - flip1995:needless_collect_appl, r=xFrednet

  Show description for a4a3f61
  bors

  committed
  a4a3f61

  Copy full SHA for a4a3f61

• Small cleanup of option_if_let_else and additional tests.

  Jarcho

  committed
  3e5dcba

  Copy full SHA for 3e5dcba

Commits on Aug 27, 2021

• Path remapping: Make behavior of diagnostics output dependent on presence of --remap-path-prefix.

  michaelwoerister

  committed
  c6c1f32

  Copy full SHA for c6c1f32

• Auto merge of rust-lang#7600 - xFrednet:0000-update-issue-templates, r=camsteffen

  Show description for 5e1e9b0
  bors

  committed
  5e1e9b0

  Copy full SHA for 5e1e9b0

Commits on Aug 28, 2021

• Treat macros as HIR items

  inquisitivecrystal

  committed
  8c4056f

  Copy full SHA for 8c4056f

• Teach tools that macros are now HIR items

  inquisitivecrystal

  committed
  c8262ad

  Copy full SHA for c8262ad

Commits on Aug 30, 2021

• rename const_evaluatable_checked to generic_const_exprs

  Show description for 0b526fd
  

  BoxyUwU

  authored and

  lcnr

  committed
  0b526fd

  Copy full SHA for 0b526fd

• feature(const_generics) -> feature(const_param_types)

  lcnr

  committed
  fd8b150

  Copy full SHA for fd8b150

• Auto merge of rust-lang#7573 - Jarcho:option_if_let_else, r=giraffate

  Show description for fd30241
  bors

  committed
  fd30241

  Copy full SHA for fd30241

Commits on Aug 31, 2021

• Fix clippy for let-else

  camsteffen

  committed
  78bf4ac

  Copy full SHA for 78bf4ac

• Check for Not trait implementation

  xordi

  committed
  f75d1b2

  Copy full SHA for f75d1b2

• Add new ui tests

  xordi

  committed
  abbcea8

  Copy full SHA for abbcea8

• Fix CI errors

  xordi

  committed
  aee4f1f

  Copy full SHA for aee4f1f

• Fix function and variable names

  xordi

  committed
  83f1454

  Copy full SHA for 83f1454

• Auto merge of rust-lang#7605 - xordi:issue-7548-fix, r=giraffate

  Show description for 87c375f
  bors

  committed
  87c375f

  Copy full SHA for 87c375f

Commits on Sep 1, 2021

• Reference new diagnostic item docs in our docs :)

  xFrednet

  committed
  0fa9bf4

  Copy full SHA for 0fa9bf4

• Update README.md

  unrealapex

  authored
  6a9549c

  Copy full SHA for 6a9549c

• rustc_target: move LayoutOf to ty::layout.

  eddyb

  committed
  8f7c249

  Copy full SHA for 8f7c249

Commits on Sep 2, 2021

• Auto merge of rust-lang#7617 - xFrednet:0000-link-diag-item-docs, r=giraffate

  Show description for 95d91d6
  bors

  committed
  95d91d6

  Copy full SHA for 95d91d6

• Auto merge of rust-lang#7619 - UnrealApex:patch-1, r=flip1995

  Show description for 849f0a1
  bors

  committed
  849f0a1

  Copy full SHA for 849f0a1

• Merge remote-tracking branch 'upstream/master' into rustup2

  flip1995

  committed
  61bb967

  Copy full SHA for 61bb967

• Fix manual_match with let-expressions

  

  camsteffen

  authored and

  flip1995

  committed
  5722a7d

  Copy full SHA for 5722a7d

• Fix dogfood

  

  camsteffen

  authored and

  flip1995

  committed
  588367b

  Copy full SHA for 588367b

• Fix remaining dogfood errors

  Show description for c7c2036
  flip1995

  committed
  c7c2036

  Copy full SHA for c7c2036

• Add higher docs and remove some unneeded fields

  

  camsteffen

  authored and

  flip1995

  committed
  c2bb313

  Copy full SHA for c2bb313

• Fix matadata collection configuration formatting

  

  xFrednet

  authored and

  flip1995

  committed
  8bf2940

  Copy full SHA for 8bf2940

• Bump nightly version -> 2021-09-02

  flip1995

  committed
  fb6839d

  Copy full SHA for fb6839d

• Fix fallout from re-applying patches

  flip1995

  committed
  01b17af

  Copy full SHA for 01b17af

• Auto merge of rust-lang#7604 - flip1995:rustup, r=Manishearth

  Show description for a8c2c7b
  bors

  committed
  a8c2c7b

  Copy full SHA for a8c2c7b

Commits on Sep 3, 2021

• Auto merge of rust-lang#88363 - michaelwoerister:remapped-diagnostics, r=estebank

  Show description for a0152da
  bors

  committed
  a0152da

  Copy full SHA for a0152da

• Extend unnecessary_unwrap to look for expect in addition to unwrap

  Show description for 03d3131
  shepmaster

  committed
  03d3131

  Copy full SHA for 03d3131

• Adjust the output of unnecessary_unwrap and provide a suggestion

  shepmaster

  committed
  b477543

  Copy full SHA for b477543

• Reorder approx_consts constant to match rust docs

  

  Michael Wright

  committed
  265b8ec

  Copy full SHA for 265b8ec

• Make approx_const MSRV aware

  Show description for a23af89
  

  Michael Wright

  committed
  a23af89

  Copy full SHA for a23af89

• Updating issue templates again for rustbot

  xFrednet

  committed
  9ebd012

  Copy full SHA for 9ebd012

• Correct link in documentation for the file clippy_lints::utils::conf

  xFrednet

  committed
  169aea6

  Copy full SHA for 169aea6

Commits on Sep 4, 2021

• Fix rust-lang#88256, remove duplicated diagnostic

  chenyukang

  committed
  6764fde

  Copy full SHA for 6764fde

• Fix documentation of eval_order_dependence

  chansuke

  committed
  b2f01ef

  Copy full SHA for b2f01ef

• needless_option_as_deref

  lengyijun

  committed
  4184cc3

  Copy full SHA for 4184cc3

• add derivable impls lint

  HKalbasi

  committed
  8221f9e

  Copy full SHA for 8221f9e

• Auto merge of rust-lang#7584 - shepmaster:unnecessary_expect, r=camsteffen

  Show description for f771927
  bors

  committed
  f771927

  Copy full SHA for f771927

• Auto merge of rust-lang#7570 - HKalbasi:derivable-impls, r=camsteffen

  Show description for a8c269a
  bors

  committed
  a8c269a

  Copy full SHA for a8c269a

Commits on Sep 5, 2021

• Update clippy_lints/src/needless_option_as_deref.rs

  Show description for 37af742
  

  lengyijun

  and

  llogiq

  authored
  37af742

  Copy full SHA for 37af742

• Add MSRV to approx_constant documentation

  

  Michael Wright

  committed
  4ee9ec9

  Copy full SHA for 4ee9ec9

• Improve approx_constant output

  

  Michael Wright

  committed
  19d8a3e

  Copy full SHA for 19d8a3e

• Avoid slice indexing in Clippy (down with the ICEs)

  xFrednet

  committed
  62b4612

  Copy full SHA for 62b4612

• Auto merge of rust-lang#7629 - mikerite:fix-7623-2, r=xFrednet

  Show description for e5ae3f5
  bors

  committed
  e5ae3f5

  Copy full SHA for e5ae3f5

• Auto merge of rust-lang#7627 - xFrednet:0000-updating-issue-templates-again, r=llogiq

  Show description for df7e63b
  bors

  committed
  df7e63b

  Copy full SHA for df7e63b

• Auto merge of rust-lang#88499 - eddyb:layout-off, r=nagisa

  Show description for ad8610d
  bors

  committed
  ad8610d

  Copy full SHA for ad8610d

• Auto merge of rust-lang#7638 - xFrednet:7569-avoid-indexing-in-clippy, r=Manishearth

  Show description for 051286d
  bors

  committed
  051286d

  Copy full SHA for 051286d

• Auto merge of rust-lang#7596 - lengyijun:option_needless_deref, r=llogiq

  Show description for 7a0d7d8
  bors

  committed
  7a0d7d8

  Copy full SHA for 7a0d7d8

Commits on Sep 6, 2021

• Auto merge of rust-lang#88493 - chenyukang:fix-duplicated-diagnostic, r=estebank

  Show description for f7aaa2a
  bors

  committed
  f7aaa2a

  Copy full SHA for f7aaa2a

• Auto merge of rust-lang#7634 - chansuke:update-eval-order-depends-docs, r=Manishearth

  Show description for 17294b8
  bors

  committed
  17294b8

  Copy full SHA for 17294b8

Commits on Sep 7, 2021

• Add TAU to approx_constant

  

  Michael Wright

  committed
  a7a5a5d

  Copy full SHA for a7a5a5d

• Auto merge of rust-lang#7642 - mikerite:fix-7641, r=flip1995

  Show description for b7c25e1
  bors

  committed
  b7c25e1

  Copy full SHA for b7c25e1

Commits on Sep 8, 2021

• Add additional test for broken loop in mut_range_bound

  dswij

  committed
  290fb8d

  Copy full SHA for 290fb8d

• mut_range_bound to check for immediate break from loop

  dswij

  committed
  8fbf75e

  Copy full SHA for 8fbf75e

• Update test output for mut_range_bound

  dswij

  committed
  7515d9c

  Copy full SHA for 7515d9c

• Add known problems to mut_range_bound docs

  dswij

  committed
  dc6f7dc

  Copy full SHA for dc6f7dc

• Auto merge of rust-lang#7607 - dswij:mut-range-bound-break, r=flip1995

  Show description for f356784
  bors

  committed
  f356784

  Copy full SHA for f356784

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  4962608

  Copy full SHA for 4962608

• Bump nightly version -> 2021-09-08

  flip1995

  committed
  3cb1d28

  Copy full SHA for 3cb1d28

• Bump Clippy Version -> 0.1.57

  flip1995

  committed
  563a00b

  Copy full SHA for 563a00b

• Auto merge of rust-lang#7644 - flip1995:rustup, r=flip1995

  Show description for 5458358
  bors

  committed
  5458358

  Copy full SHA for 5458358

• Remove unused dependencies

  

  camsteffen

  authored and

  flip1995

  committed
  ffe21e5

  Copy full SHA for ffe21e5

• Use binary-dep-depinfo to resolve UI dependencies

  

  camsteffen

  authored and

  flip1995

  committed
  8c05a15

  Copy full SHA for 8c05a15

• Deny warnings in test modules

  camsteffen

  committed
  5d3fc6f

  Copy full SHA for 5d3fc6f

• Auto merge of rust-lang#7631 - camsteffen:depinfo, r=flip1995

  Show description for 27afd6a
  bors

  committed
  27afd6a

  Copy full SHA for 27afd6a

• Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup

  flip1995

  committed
  7636fbc

  Copy full SHA for 7636fbc

• Update Cargo.lock

  flip1995

  committed
  fe247b4

  Copy full SHA for fe247b4