-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #3805 - wrap macro that starts with nested body blocks #5582
Fix for #3805 - wrap macro that starts with nested body blocks #5582
Conversation
Thanks for your help on this! I left two minor comments inline. Let me know your thoughts on both points. |
Accepted the suggested changes, with minor change to the first comment. Note also my note about the formatted output of new nest case with multi |
804a4b6
to
643f32c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help fixing this issue, and for applying the feedback. I think we're good to go here!
I'm good with this change, but it will need to be version gated @davidBar-On is that something you'd be willing to do when you have time? |
643f32c
to
b1fecdd
Compare
Added the version gating. Based on version other gating code, I used |
b1fecdd
to
b9cc509
Compare
This one has been marked as ready-to-merge for a while, and the fix has been version gated. Everything continues to pass after rebasing so I think we're good to go here. |
Fixes #3805
For wrapping macros with body block that starts with more than one
{
, i.e. starts with "nested blocks". The issue cause was that the nested block(s){
were not considered for calculating the remaining line width.