5796 derive attribute is not wrapped if it's exactly max length #6021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5796
This is not the prettiest solution but there is a assumption that once we enter
write_list
forlist.rs
we always subtract the separator from the width. This is causing the bug to occur here. As the line exceeds that max width by 1 and this subtraction makes the formatter think it is equal.So the
item_str
we get back is actually greater than the width so I do a check for this and format it again but this time vertically.I don't think this is pretty or a optimal fix (as we've to format twice) but I wanted to open a PR to generate a conversation about it. Maybe we can discuss a better solution to the problem now it has been identified a little more.